`clang-tidy`: resolve `bugprone-throwing-static-initialization` by greenc-FNAL · Pull Request #472 · Framework-R-D/phlex

greenc-FNAL · 2026-03-30T20:28:02Z

Namespace-scope statics with non-trivial constructors (e.g. std::string, std::unordered_map) trigger bugprone-throwing-static-initialization because their constructors can throw before main(). The fix moves all such statics to function-local scope (guaranteed-lazy, exception-safe initialization).

Changes

phlex/core/detail/filter_impl.cpp — Wraps output_dummy and for_output_only_queries in a function returning product_queries const&. Also fixes a latent bug: the original return-by-value caused data_map::input_products_ to point to a destroyed temporary.
phlex/model/data_layer_hierarchy.cpp — Moves unnamed into maybe_name() as a static std::string const.
form/root_storage/root_tbranch_write_container.cpp — Moves typeNameToLeafList from namespace scope into setupWrite(). Map remains non-const with operator[] access: an unmapped fundamental type produces an empty leaf list, which ROOT silently treats as Float_t — this is intentional.
scripts/clang_tidy_fixes_to_problems.py — Fixes ruff I001/D101/D103 issues (import order, missing docstrings).
test/filter_impl.cpp — Adds "Data map for output only" test exercising data_map(for_output_t) to cover the new for_output_only() function.
test/data_cell_counting.cpp — Adds "Data layer hierarchy with unnamed layer" test; a child with an empty layer name triggers the maybe_name("") → "(unnamed)" path via the destructor's graph_layout() call.

codecov · 2026-03-30T20:43:53Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
+ Coverage   85.49%   85.58%   +0.08%     
==========================================
  Files         142      142              
  Lines        3586     3601      +15     
  Branches      615      616       +1     
==========================================
+ Hits         3066     3082      +16     
+ Misses        311      310       -1     
  Partials      209      209

Flag	Coverage Δ
unittests	`85.58% <100.00%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
form/root_storage/root_tbranch_write_container.cpp	`79.36% <100.00%> (+3.89%)`	⬆️
phlex/core/detail/filter_impl.cpp	`97.82% <100.00%> (+2.58%)`	⬆️
phlex/model/data_layer_hierarchy.cpp	`100.00% <100.00%> (+1.81%)`	⬆️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e67db...7b48c74. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

greenc-FNAL · 2026-03-30T22:08:57Z

@phlexbot tidy-fix -* bugprone-throwing-static-initialization

github-actions · 2026-03-30T22:14:34Z

No automatic clang-tidy fixes were necessary.

greenc-FNAL · 2026-03-30T22:42:10Z

@phlexbot tidy-fix -* bugprone-throwing-static-initialization

github-actions · 2026-03-30T22:47:54Z

No automatic clang-tidy fixes were necessary.

greenc-FNAL · 2026-04-06T20:52:23Z

@copilot Please fix the ruff issues identified in https://github.com/Framework-R-D/phlex/actions/runs/24050124627/job/70143404406?pr=472

Copilot

Pull request overview

This PR addresses clang-tidy’s bugprone-throwing-static-initialization warnings by removing or deferring non-trivial static initialization in a few translation units and tests.

Changes:

Replaced inline std::string test constants with constexpr char const* and updated call sites to construct std::string where required.
Moved namespace-scope/static initializations to function-local statics (or fixtures) to avoid static initialization before main().
Refactored a ROOT leaf-list type mapping table from namespace scope into setupWrite().

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`test/form/test_utils.hpp`	Uses `constexpr` C-string literals for test file/tree names and adjusts string concatenation/calls accordingly.
`test/data_cell_counting.cpp`	Defers `_idq.hash` initialization via a Catch2 fixture helper.
`phlex/model/data_layer_hierarchy.cpp`	Reworks unnamed-layer formatting helper to avoid non-local static initialization.
`phlex/core/detail/filter_impl.cpp`	Replaces namespace-scope statics with a helper function for output-only query defaults.
`form/root_storage/root_tbranch_write_container.cpp`	Moves the type-to-leaf-list map into `setupWrite()` as a function-local static.

- Per #472 (comment)

greenc-FNAL · 2026-04-07T23:16:06Z

@copilot Please add/augment tests as necessary to resolve the coverage gaps introduced by this PR as reported at https://github.com/Framework-R-D/phlex/pull/472/checks?check_run_id=70336551759

Copilot · 2026-04-07T23:24:10Z

@copilot Please add/augment tests as necessary to resolve the coverage gaps introduced by this PR as reported at https://github.com/Framework-R-D/phlex/pull/472/checks?check_run_id=70336551759

Added two new tests in 2c39c2d:

"Data map for output only" in test/filter_impl.cpp — exercises data_map(for_output_t) to cover the new for_output_only() function (5 missing lines in phlex/core/detail/filter_impl.cpp).
"Data layer hierarchy with unnamed layer" in test/data_cell_counting.cpp — creates a child layer with an empty name, which triggers the maybe_name("") → "(unnamed)" branch in phlex/model/data_layer_hierarchy.cpp (the 1 partial line) via the destructor's print() → graph_layout() → pretty_recurse() call chain.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

app.codecov.io
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

- Per #472 (comment)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Agent-Logs-Url: https://github.com/Framework-R-D/phlex/sessions/5501225a-2e96-449f-94e4-a1dc4a613a1c Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

…tempts

…t is intentional Agent-Logs-Url: https://github.com/Framework-R-D/phlex/sessions/cb3139bb-776b-463b-8198-38267887c6a7 Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

- Per #472 (comment)

Agent-Logs-Url: https://github.com/Framework-R-D/phlex/sessions/d1188b31-3b1a-484b-8300-701ba55a692a Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

greenc-FNAL force-pushed the maintenance/clang-tidy-fixes-2026-03-31 branch from bbfe20c to 3c844a9 Compare March 30, 2026 20:34

greenc-FNAL force-pushed the maintenance/clang-tidy-fixes-2026-03-31 branch from 07b2261 to fde2d7b Compare March 30, 2026 22:22

greenc-FNAL force-pushed the maintenance/clang-tidy-fixes-2026-03-31 branch 3 times, most recently from 28c33b7 to 971666b Compare April 3, 2026 04:14

Copilot started work on behalf of greenc-FNAL April 6, 2026 20:52 View session

Copilot finished work on behalf of greenc-FNAL April 6, 2026 20:55

greenc-FNAL force-pushed the maintenance/clang-tidy-fixes-2026-03-31 branch 6 times, most recently from a5dc634 to 1596018 Compare April 7, 2026 20:12

greenc-FNAL changed the title ~~[WIP] More clang-tidy fixes~~ Resolve bugprone-throwing-static-initialization warnings from clang-tidy Apr 7, 2026

greenc-FNAL marked this pull request as ready for review April 7, 2026 20:13

Copilot AI review requested due to automatic review settings April 7, 2026 20:13

Copilot AI reviewed Apr 7, 2026

View reviewed changes

Comment thread phlex/core/detail/filter_impl.cpp Outdated

Comment thread test/data_cell_counting.cpp Outdated

Comment thread form/root_storage/root_tbranch_write_container.cpp

Copilot started work on behalf of greenc-FNAL April 7, 2026 20:21 View session

Copilot AI changed the title ~~Resolve bugprone-throwing-static-initialization warnings from clang-tidy~~ More clang-tidy fixes and ruff docstring/import cleanup Apr 7, 2026

Copilot finished work on behalf of greenc-FNAL April 7, 2026 20:26

Framework-R-D deleted a comment from Copilot AI Apr 7, 2026

greenc-FNAL changed the title ~~More clang-tidy fixes and ruff docstring/import cleanup~~ Resolve bugprone-throwing-static-initialization warnings from clang-tidy Apr 7, 2026

greenc-FNAL requested a review from Copilot April 7, 2026 20:33

Copilot started reviewing on behalf of greenc-FNAL April 7, 2026 20:33 View session

greenc-FNAL added a commit that referenced this pull request Apr 7, 2026

constexpr -> const

bc02bd7

- Per #472 (comment)

Copilot started work on behalf of greenc-FNAL April 7, 2026 23:16 View session

Copilot finished work on behalf of greenc-FNAL April 7, 2026 23:25

greenc-FNAL requested review from Copilot and knoepfel April 8, 2026 00:08

Copilot started reviewing on behalf of greenc-FNAL April 8, 2026 00:09 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread test/data_cell_counting.cpp Outdated

greenc-FNAL changed the title ~~Resolve bugprone-throwing-static-initialization clang-tidy warnings~~ clang-tidy: resolve bugprone-throwing-static-initialization Apr 8, 2026

knoepfel reviewed Apr 8, 2026

View reviewed changes

Comment thread docs/dev/clang-tidy-fixes-2026-04.md

greenc-FNAL force-pushed the maintenance/clang-tidy-fixes-2026-03-31 branch from 2d14746 to 4c607aa Compare April 8, 2026 13:54

greenc-FNAL added a commit that referenced this pull request Apr 8, 2026

cached_hash should be const

547cd87

- Per #472 (comment)

greenc-FNAL added a commit that referenced this pull request Apr 8, 2026

constexpr -> const

8c12df2

- Per #472 (comment)

greenc-FNAL force-pushed the maintenance/clang-tidy-fixes-2026-03-31 branch from 4c607aa to 4b1ed51 Compare April 8, 2026 13:58

greenc-FNAL and others added 10 commits April 8, 2026 09:24

Resolve bugprone-throwing-static-initialization clang-tidy warnings

95884d6

Update test/data_cell_counting.cpp

381db61

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Return const& from for_output_only() to avoid dangling pointer

606181a

Agent-Logs-Url: https://github.com/Framework-R-D/phlex/sessions/5501225a-2e96-449f-94e4-a1dc4a613a1c Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

Prevent unwanted empty entries for missing fundamental type access at…

a35ae09

…tempts

Revert typeNameToLeafList to non-const with [] access; empty leaf lis…

e819f5a

…t is intentional Agent-Logs-Url: https://github.com/Framework-R-D/phlex/sessions/cb3139bb-776b-463b-8198-38267887c6a7 Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

cached_hash should be const

76d7ec6

- Per #472 (comment)

Report on clang-tidy fix progress

efc7d1c

constexpr -> const

8562839

- Per #472 (comment)

Add tests for filter_impl.cpp and data_layer_hierarchy.cpp coverage gaps

6898384

Agent-Logs-Url: https://github.com/Framework-R-D/phlex/sessions/d1188b31-3b1a-484b-8300-701ba55a692a Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

Update test/data_cell_counting.cpp

7b48c74

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

greenc-FNAL force-pushed the maintenance/clang-tidy-fixes-2026-03-31 branch from 4b1ed51 to 7b48c74 Compare April 8, 2026 14:24

greenc-FNAL requested a review from knoepfel April 8, 2026 14:33

knoepfel approved these changes Apr 8, 2026

View reviewed changes

knoepfel merged commit aaedaf5 into main Apr 8, 2026
36 checks passed

knoepfel deleted the maintenance/clang-tidy-fixes-2026-03-31 branch April 8, 2026 14:43

Conversation

greenc-FNAL commented Mar 30, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

codecov bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

greenc-FNAL commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

greenc-FNAL commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

greenc-FNAL commented Apr 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greenc-FNAL commented Apr 7, 2026

Uh oh!

Copilot AI commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

greenc-FNAL commented Mar 30, 2026 •

edited by Copilot AI

Loading

codecov bot commented Mar 30, 2026 •

edited

Loading

Copilot AI commented Apr 7, 2026 •

edited

Loading